Update domain controller sAMAccountName value#957
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates domain controller naming to consistently use the host’s short name (pre-FQDN dot) via a new computed setting, avoiding dotted values in places like sAMAccountName.
Changes:
- Added
Settings.HOST_MACHINE_SHORT_NAMEcomputed field derived fromHOST_MACHINE_NAME. - Switched domain controller
name/sAMAccountNamewrites to useHOST_MACHINE_SHORT_NAMEduring initial setup and DC creation script. - Updated the existing Alembic migration that creates the “Domain Controllers” OU to also use
HOST_MACHINE_SHORT_NAME.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| app/ldap_protocol/auth/use_cases.py | Uses short host name when creating the initial Domain Controller directory + sAMAccountName. |
| app/extra/scripts/add_domain_controller.py | Uses short host name for DC directory name and related attributes when adding DC post-setup. |
| app/config.py | Introduces HOST_MACHINE_SHORT_NAME computed field. |
| app/alembic/versions/ebf19750805e_add_domain_controllers_ou.py | Updates OU/DC creation logic in an existing migration to use the short host name. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Naksen
changed the title
milov-dmitriy
approved these changes
Mar 5, 2026
Naksen
added a commit
that referenced
this pull request
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.